developer: use server passage budget from search#843 - #194
Open
PhantomInTheWire wants to merge 2 commits into
Open
developer: use server passage budget from search#843#194PhantomInTheWire wants to merge 2 commits into
PhantomInTheWire wants to merge 2 commits into
Conversation
Member
Author
|
@cubic-dev-ai review |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Member
Author
|
@cubic-dev-ai review |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passage_budgeton every developer-search request--passage-budgetand pass custom values through to the serverpassage_budget_appliedis presentThe default is 4,096 approximate tokens. The old formatter capped each result's joined passages at 1,200 characters (about 300 tokens), or about 3,000 passage tokens across the default 10 results; 4,096 preserves that intent with allocation headroom.
The fallback has a TODO to remove after firecrawl/search#843 is enabled everywhere.
Verification
pnpm run format:checkpnpm run type-checkpnpm run buildpnpm run test(424 passed)Summary by cubic
Delegate passage sizing for developer search to the server and add a
--passage-budgetflag. Previously readable output clipped passages to 1,200 characters; now the CLI sends a token budget and only clips locally when the server omits budget metadata. Default is 4,096 tokens.passage_budgetto all/v2/search/developerrequests (default 4096; range 256–16384);--passage-budgetpasses through and is validated, rejecting out-of-range or non-integer values.passage_budget_appliedis present; keep the 1,200-character fallback for older servers.Written for commit f3712e9. Summary will update on new commits.