docs(skills): fix command guidance, auth requirements, and workflow drift - #193
Merged
Max17190 merged 16 commits intoAug 18, 2026
Merged
Conversation
Make download examples safe for non-interactive flows and correct agent JSON guidance in the README. Include skill Markdown in Prettier scripts so formatting drift is caught.
Adversarial review against src/ surfaced wrong claims that survived the first audit pass, in the same files this PR touches: - scrape: -H is --html (raw HTML shortcut), not HTTP headers - interact: --language does not exist; the CLI uses --node/--python/--bash - download: the command is only registered as 'firecrawl x download' (experimental), so all examples used a nonexistent invocation; the 'only these options' list omitted --lockdown; the wizard example is TTY-only and blocks agents without -y - search: spell out guard-failure behavior and split the missing-file vs stale-file hazards - scrape/agent: reword confusing multi-URL parenthetical and dedupe the --wait tip - cli: mirror the guarded jq search-id recipe so it doesn't drift from the corrected search skill
This was referenced Aug 18, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 12 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
A bare SEARCH_ID=$(jq -er ...) assignment does not stop the follow-on search-feedback call when the guard fails (missing file or zero results), so it fired with an empty id. Wrap the feedback call in the guard conditional in both mirrored snippets.
Max17190
requested changes
Aug 18, 2026
…ter name The installer copies each skill to ~/.agents/skills/<frontmatter-name>/, and the router skill is named "firecrawl", so ../firecrawl-cli/SKILL.md links 404ed after install. Rename the folder to skills/firecrawl/ so the folder and frontmatter agree and cross-skill links resolve both in-repo and installed.
Contributor
|
…uard Update the .claude-plugin skill paths missed by the folder rename, and move the three search-feedback examples inside the guard conditional so copying any of them cannot bypass the zero-result check.
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
All three rating calls were live sequential commands inside the guard, so a literal copy-paste submitted three conflicting ratings for one search id. Keep the good-rating call live and show partial/bad as commented alternates, matching the "send exactly one" prose.
Replace the three parallel rating examples (latterly commented alternates) with a single guarded good-rating call. The rules list above already defines per-rating field requirements and the --missing-content section documents payload shapes, so the extra examples duplicated both. Follows the default-with-escape-hatch pattern and matches the mirrored firecrawl skill snippet.
…ased A live --rating good default anchors copy-paste agents toward reporting good and skews the feedback signal. Show a <good|partial|bad> placeholder that cannot run until the agent chooses, keep the rating-neutral --missing-content field as the worked example, and let the rules list govern per-rating required fields. Applied to both mirrored snippets.
chenxin-yan
force-pushed
the
skills/consolidated-docs-fixes
branch
from
August 18, 2026 19:30
5c62a86 to
d3d3ff0
Compare
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
The collapsed example only sent --missing-content, so substituting --rating good violated the valuable-sources requirement and the --silent call swallowed the HTTP 400, silently losing the refund. Show both --valuable-sources and --missing-content so any rating substitution satisfies the substantive-content rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates #189, #190, #191, and #192 into one reviewable change.
npx firecrawl-cliallowed-tools pattern and broken cross-skill linksVerification
pnpm run format:checkpnpm run type-checkpnpm testAll pass locally.
Supersedes #189, #190, #191, and #192.