-
Notifications
You must be signed in to change notification settings - Fork 92
docs(skills): fix behavior claims that don't match the CLI #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,13 +135,13 @@ Search costs 2 credits. After you've actually used the results (or decided they | |
| - **Idempotent:** re-submitting for the same search id returns success but no extra refund. | ||
| - **`--silent &`** is the right pattern — exit code 0 even on failure, so a rejected/expired call never crashes your pipeline. | ||
|
|
||
| Read the search response's `id`: | ||
| Verify the search returned results before reading its `id`. Zero-result searches write no output file, so the file may be missing — or left over from an earlier search. Only send feedback when this guard succeeds: | ||
|
|
||
| ```bash | ||
| SEARCH_ID=$(jq -r '.id' .firecrawl/search-react-hooks.json) | ||
| SEARCH_ID=$(jq -er 'select(any(.data[]; length > 0)) | .id' .firecrawl/search-react-hooks.json) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: The guard only detects a missing/empty result file; it cannot detect a stale file left over from an earlier search. The same fixed path ( Prompt for AI agents</file context> |
||
| ``` | ||
|
|
||
| Then send feedback. Pick the rating that matches what actually happened: | ||
| If the guard fails (non-zero exit: missing file or zero results), skip feedback. Otherwise pick the rating that matches what actually happened: | ||
|
|
||
| ```bash | ||
| # Results were useful, with notes on what was still missing | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: The
-f/--formatlist is incomplete: it omitsscreenshot,changeTracking, andbranding. Parse's--formatis parsed by the sharedparseFormatsinsrc/utils/options.ts, which accepts all 11VALID_FORMATS(markdown, html, rawHtml, links, images, screenshot, summary, changeTracking, json, attributes, branding) and rejects nothing at parse time. The doc reads as an exhaustive list, so an agent will believe those three values are invalid and the accuracy goal of this PR is not fully met. Either add the missing values or state that only these 8 are meaningful for parse.Prompt for AI agents