Fixing an issue that when plugin *.dll file is deleted - it will not be reinstalled - making the file to be using KeyPath instead of registry entry#186
Open
wojwal wants to merge 1 commit intofirebreath:2.0from
Conversation
Member
|
This should work fine w/ HKLM, but HKCU usually installs to the user profile directory and you can't use a file in the user profile directory as a KeyFile, which is why it's done the way it's done. I'm open to other suggestions :-/ Unfortunately this will break a per-user install. |
Member
Author
|
Intresting... I'm using HKLM myself - and I didn't realize KeyPath doesn't work for files in user profile. I'll try that - if that will not work... I'll remove HKCU change. But I guess this issue is far more probable for HKLM - some users tends to go to C:\Program Files\ and delete files... While I guess avarage user will not be able to find his own profile directory - since that's hidden by default. |
…be reinstalled - making the file to be using KeyPath instead of registry entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Richard,
I have some complains from users that their plugins didn't work... In case they manually delete plugin DLL file - and later tried to install MSI again - it's not reinstalling the component which includes DLL file. Basically they went and deleted all files themselves - leaving all other things like Registry untouched.
The reason is that "KeyPath" is made for registry entry - so only if that one is removed it would reinstall it.
I've already solved all other files in my custom WXS so that each file is separate component with "KeyPath=yes" - but the DLL file is inside auto-generated WXS file.
Applying a change for Wix Templates.
Not commiting directly to FB 2.0 branch - just wanted to make sure you are OK with it ;)