FIREBREATH-236 & FIREBREATH-237 Patch#110
Open
wavesoft wants to merge 5 commits intofirebreath:masterfrom
Open
FIREBREATH-236 & FIREBREATH-237 Patch#110wavesoft wants to merge 5 commits intofirebreath:masterfrom
wavesoft wants to merge 5 commits intofirebreath:masterfrom
Conversation
added 5 commits
June 26, 2013 11:41
Added progress and data chunk feedback
Fixed a bug on SimpleStreamHelper::SynchronousRequest
Integrating the more advanced SimpleStreamHelper interface with other components of FireBreath core.
Using FB::BrowserStream->getLength() instead of custom header parsing function.
Member
|
I'm sorry, I recently discovered that I haven't been getting notified of pull requests and have been so busy the last 6-8 months I didn't notice. Could you rebase this on master and then push -f so that I have a clean request that can be merged? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch solves a bug on SimpleStreamHelper::SynchronousRequest( ) and adds some new features on SimpleStreams. Namely:
BrowserStreamRequest::setProgressCallback( )in order to receive feedback regarding the download progress.BrowserStreamRequest::setChunkCallback( )in order to implement a custom data receiving function.BrowserStreamRequest::setCompletedCallback( )in order forward the notification of download completion.The HttpProgressCallback can even be used with the classic HttpCallback interface.