Open
Conversation
stouretski-fb
force-pushed
the
PIK-4658-payment-flows
branch
2 times, most recently
from
8ef1f03 to
e35bf7d
Compare
stouretski-fb
force-pushed
the
PIK-4658-payment-flows
branch
from
e35bf7d to
ad44a92
Compare
eytanacht
approved these changes
May 6, 2024
| * Execute payment workflow | ||
| * @param workflowExeuctionId | ||
| */ | ||
| public async executePaymentFlow(workflowExeuctionId: string): Promise<Payments.WorkflowExecution> { |
There was a problem hiding this comment.
Just to keep the same pattern, this is the only endpoint with the word Flow instead of Workflow.
I guess it came from our code but maybe it's better to change it here.
| * Format: uuid | ||
| * @description The related workflow id that executes the failure handling | ||
| */ | ||
| workflowExecutionId?: string; |
There was a problem hiding this comment.
the new structure:
execution?: {
executionId: string;
status: WorkflowExecutionStatus;
};
Comment on lines
+12
to
+14
| export interface AnyAdditionalPropertiesSchema { | ||
| [key: string]: unknown; | ||
| } |
There was a problem hiding this comment.
that's fine.
since we need to allow Record<string, unknown> values, in the openapi the way to do that is by a schema of an object with additionalProperties: { }.
This is the reason for this weird interface.
We can change here every usage of this interface to the actual type, but in my opinion we can leave it like that for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes (link to the issue here)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: