Add mergeConfig option to opt out of implicit config object merging#536
Open
swseverance wants to merge 1 commit into
Open
Add mergeConfig option to opt out of implicit config object merging#536swseverance wants to merge 1 commit into
swseverance wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mergeConfig option to Superstatic, allowing users to provide a configuration object that is not merged with existing superstatic.json or firebase.json files. The changes include updates to the configuration loader, middleware options, and documentation, along with new unit tests. Feedback identifies a potential bug where mergeConfig: false incorrectly handles file paths, and suggests a logic adjustment and an additional test case to ensure correct behavior.
When a plain object is passed as config via the programmatic API, superstatic merges it with any superstatic.json or firebase.json found on disk. Add mergeConfig: false to use the provided object as-is. This only affects programmatic usage — the CLI always uses the specified config file directly and was never subject to merging. Resolves firebase#503
swseverance
force-pushed
the
feature/no-merge
branch
from
5e3b3c8 to
5d0f0ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plain object is passed as config via the programmatic API, superstatic merges it with any superstatic.json or firebase.json found on disk. Add mergeConfig: false to use the provided object as-is.
This only affects programmatic usage — the CLI always uses the specified config file directly and was never subject to merging.
Resolves #503