-
Notifications
You must be signed in to change notification settings - Fork 620
feat(py):add mcp plugin and relevant tests #4023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Model Context Protocol (MCP) into the Python Genkit SDK, significantly enhancing its interoperability capabilities. It introduces a new 'resource' action type, allowing developers to define and manage content accessible via URIs. The new MCP plugin provides both client and server functionalities, enabling Genkit applications to consume services from other MCP-compliant systems and expose their own tools, prompts, and resources. This lays the groundwork for a more connected and extensible Genkit ecosystem. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant new feature, the MCP plugin for Python, along with comprehensive examples and tests. The overall structure and implementation are well-done. I've identified a critical bug related to an undefined function that will prevent the server from working, as well as several opportunities for improvement in terms of code efficiency, clarity, and robustness. My comments focus on addressing these points to enhance the quality of the new plugin.
This big changes aims to add mcp plugin to mirror all the functionalities in js/plugins/mcp in JS SDK.
CHANGELOG: