Skip to content

Conversation

@MengqinShen
Copy link
Contributor

@MengqinShen MengqinShen commented Dec 30, 2025

This big changes aims to add mcp plugin to mirror all the functionalities in js/plugins/mcp in JS SDK.
CHANGELOG:

  1. Added a plugin to enable Genkit applications to interact with the Model Context Protocol, allowing them to function as both clients and servers.
  2. Added a 'resource' action kind to Genkit, enabling the definition and management of URI-addressable content
  3. MCP Client Implementation: Provided a client that can connect to external MCP servers, list their tools, prompts, and resources, and execute them within a Genkit application.
  4. MCP Server Implementation: Developed a server that exposes Genkit's registered tools, prompts, and resources to external MCP clients, facilitating interoperability.
  5. Included extensive unit and integration tests for the MCP plugin, covering client-server communication, resource handling, and conversion utilities.

@github-actions github-actions bot added docs Improvements or additions to documentation python Python config labels Dec 30, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the Model Context Protocol (MCP) into the Python Genkit SDK, significantly enhancing its interoperability capabilities. It introduces a new 'resource' action type, allowing developers to define and manage content accessible via URIs. The new MCP plugin provides both client and server functionalities, enabling Genkit applications to consume services from other MCP-compliant systems and expose their own tools, prompts, and resources. This lays the groundwork for a more connected and extensible Genkit ecosystem.

Highlights

  • Model Context Protocol (MCP) Plugin: Introduced a new Python plugin to enable Genkit applications to interact with the Model Context Protocol, allowing them to function as both clients and servers.
  • New Resource Action Type: Added a 'resource' action kind to Genkit, enabling the definition and management of URI-addressable content, which can be accessed via fixed URIs or URI templates.
  • MCP Client Implementation: Provided a client that can connect to external MCP servers, list their tools, prompts, and resources, and execute them within a Genkit application.
  • MCP Server Implementation: Developed a server that exposes Genkit's registered tools, prompts, and resources to external MCP clients, facilitating interoperability.
  • Enhanced Prompt Definition: Modified the 'define_prompt' function to allow explicit naming of prompts, enabling their registration as discoverable actions for MCP and Dev UI.
  • Comprehensive Testing: Included extensive unit and integration tests for the MCP plugin, covering client-server communication, resource handling, and conversion utilities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant new feature, the MCP plugin for Python, along with comprehensive examples and tests. The overall structure and implementation are well-done. I've identified a critical bug related to an undefined function that will prevent the server from working, as well as several opportunities for improvement in terms of code efficiency, clarity, and robustness. My comments focus on addressing these points to enhance the quality of the new plugin.

@MengqinShen MengqinShen requested a review from yesudeep December 30, 2025 04:13
@MengqinShen MengqinShen marked this pull request as ready for review December 30, 2025 04:14
@yesudeep yesudeep requested a review from zarinn3pal December 30, 2025 06:20
@MengqinShen MengqinShen requested review from zarinn3pal and removed request for zarinn3pal December 30, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config docs Improvements or additions to documentation python Python

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants