-
Notifications
You must be signed in to change notification settings - Fork 620
fix(go): filter out non-genkit traces from dev ui #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: devmanishofficial <devmanishofficial@gmail.com>
Summary of ChangesHello @DEVMANISHOFFL, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a usability issue in the Dev UI where internal HTTP traces were cluttering the display, making it difficult to focus on relevant AI flow traces. The solution involves introducing a filtering layer for OpenTelemetry spans, ensuring that only traces directly related to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a filteringExporter to filter out non-genkit traces from the dev UI, which is a great improvement for reducing noise. The implementation is clear and effectively solves the issue. I've added a couple of suggestions to improve performance and maintainability by pre-allocating a slice and using an existing constant instead of a magic string. Overall, this is a solid contribution.
| } | ||
|
|
||
| func (e *filteringExporter) ExportSpans(ctx context.Context, spans []sdktrace.ReadOnlySpan) error { | ||
| var genkitSpans []sdktrace.ReadOnlySpan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better performance and to avoid potential reallocations within the loop, it's a good practice to pre-allocate the slice with a known capacity. This ensures that the backing array for the slice is allocated only once.
| var genkitSpans []sdktrace.ReadOnlySpan | |
| genkitSpans := make([]sdktrace.ReadOnlySpan, 0, len(spans)) |
|
|
||
| func isGenkitSpan(span sdktrace.ReadOnlySpan) bool { | ||
| for _, attr := range span.Attributes() { | ||
| if strings.HasPrefix(string(attr.Key), "genkit") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@google-gemini-code-assist Thanks for the review! I have applied the suggested fixes:
Note on CI: |
|
Thanks for the update, @DEVMANISHOFFL! I appreciate you addressing the suggestions. Regarding the CI failure in Let me know if you need any further assistance! |
Description
This PR addresses the issue where the Dev UI becomes cluttered with internal HTTP traces (e.g., standard
net/httpclient calls) that are not relevant to the developer's AI flows.I implemented a
filteringExportermiddleware for the OpenTelemetry TracerProvider. This ensures that only spans explicitly containinggenkitattributes are exported to the Dev UI, filtering out background noise while preserving all relevant AI traces.Issues Resolved
Fixes #3984
Checklist (if applicable):