Add assertions for new Remote Config value types in createTemplateFromJSON test #3047
Conversation
…mJSON test Updates the `createTemplateFromJSON` unit test to include specific assertions for `new_ui_enabled`, `personalized_welcome_message`, and `experiment_enabled` parameters. This ensures that Rollout, Personalization, and Experiment value types are correctly handled when creating a template from a JSON string.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
| expect(p2.conditionalValues).deep.equals({ | ||
| ios: { | ||
| rolloutValue: { | ||
| rolloutId: 'rollout_1', | ||
| value: 'true', | ||
| percent: 50, | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
Use the newly defined interfaces to perform the assertions instead of deep checks. For example, in this case, extract the conditional values into a variable of type RolloutParameterValue and assert on individual fields.
Do the same for subsequent assertions as well for types like PersonalizationParameterValue and ExperimentParameterValue.
There was a problem hiding this comment.
Refactored the assertions to use the explicit RolloutParameterValue, PersonalizationParameterValue, and ExperimentParameterValue interfaces, and asserted on individual fields as requested.
Updates the `createTemplateFromJSON` unit test to explicitly cast conditional values to `RolloutParameterValue`, `PersonalizationParameterValue`, and `ExperimentParameterValue` interfaces. Asserts on individual fields of these values instead of generic object equality checks. Exports the necessary interfaces from `src/remote-config/index.ts` to support these assertions.
ashish-kothari
deleted the
remote-config-test-assertions-2202110623002317253
branch
1 participant
This PR updates the
createTemplateFromJSONunit test intest/unit/remote-config/remote-config.spec.ts.Previously, the test only asserted on
holiday_promo_enabled. This change adds assertions for:new_ui_enabled(Rollout)personalized_welcome_message(Personalization)experiment_enabled(Experiment)These assertions verify that
defaultValue,conditionalValues,description, andvalueTypeare correctly parsed and set for these new value types.PR created automatically by Jules for task 2202110623002317253 started by @ashish-kothari