feat(rc): Support Rollout, Personalization, and Experiment values

[ashish-kothari]

feat(remote-config): Support Rollout, Personalization, and Experiment values

Added new Remote Config parameter value types (Rollout, Personalization, Experiment) to the SDK.
Updated RemoteConfigParameterValue union type and added corresponding interfaces.
Updated unit tests to verify the new types in Remote Config templates.
Fixes #2962.

[gemini-code-assist]

Summary of Changes

Hello @ashish-kothari, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Remote Config SDK by integrating advanced parameter value types: Rollout, Personalization, and Experiment. This expansion allows developers to implement more sophisticated feature rollout strategies, tailor user experiences, and conduct A/B tests directly through Remote Config, providing greater control and flexibility over application behavior without requiring app updates.

Highlights

• New Remote Config Parameter Value Types: Introduced support for 'Rollout', 'Personalization', and 'Experiment' as new parameter value types within the Remote Config SDK.
• Expanded RemoteConfigParameterValue Union Type: The RemoteConfigParameterValue union type has been updated to include the newly defined RolloutParameterValue, PersonalizationParameterValue, and ExperimentParameterValue interfaces, allowing for more flexible configuration options.
• New Interfaces and Type Aliases: Added several new interfaces and type aliases, such as RolloutValue, PersonalizationValue, ExperimentValue, and their variants, to formally define the structure of these new parameter types.
• Unit Test Coverage: Updated unit tests to include examples and verification for the new Rollout, Personalization, and Experiment value types, ensuring their correct handling and integration within Remote Config templates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for Rollout, Personalization, and Experiment value types in Remote Config templates. The new TypeScript interfaces are well-defined and follow good practices.

However, I've identified a critical issue: the server-side evaluation logic in ServerTemplateImpl.evaluate() has not been updated to handle these new value types. This will cause silent failures and result in incorrect configuration values being returned when these new types are used. This logic must be updated to either correctly evaluate the new types or explicitly fail if they are not supported for server-side evaluation.

Additionally, while test data for the new types has been added, the unit tests for createTemplateFromJSON are missing specific assertions to verify that these new types are parsed correctly.

My review includes detailed comments on these points.