Better handling stop datafeed#839
Merged
Yannick-Malins merged 3 commits intofinos:mainfrom Oct 20, 2025
Merged
Conversation
Sometime datafeed is not stopped after calling stop(). I identified a specific case, where the stop command is send while datafeed is still initilizing (and it can take time), as the stop flag was overwritten by pending start process
This reverts commit 56c4e38.
symphony-enrico
commented
Oct 20, 2025
| @Override | ||
| public void start() throws AuthUnauthorizedException, ApiException { | ||
| if (this.started.get()) { | ||
| if (!this.started.compareAndSet(false, true)) { |
Contributor
Author
There was a problem hiding this comment.
Datafeed start flag must be check and set with an atomic operation as very first command of start/stop APIs (or both API must be synchronized, but I preferred to avoid this, also for using VirtualThread on client side for registering listeners).
Otherwise, during the start command, started flag was set only inside runLoop method, but I take some time to arrive on it (before, there is datafeed initialization) and we can have concurrency issue stopping it
sbenmoussati
approved these changes
Oct 20, 2025
vladokrsymphony
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime datafeed is not stopped after calling stop().
I identified one specific case:
This PR solve this specific case