Remove numpy dependency - #70
Merged
Merged
Conversation
This is a big depedency with barely any value for the main code, with many difficulties with development (e.g., typing), keeping up with new Python versions etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numpy is a big dependency, and we barely use it in the main code.
Besides, it makes it difficult to keep up with new Python versions as they require different numpy versions to support and are hard on type hints.
The distance matrices calculation will lose speed, but this is a one-time task.
The library will still accept numpy arrays as input, but will treat them as lists of lists.