Skip to content

Add redis to filibuster opentelemetry library #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eunicech wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add redis to filibuster opentelemetry library #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
adb9023
added redis folder to fork redis
Mar 30, 2022
f2a8a9d
fixed failing _instrumentor code
Mar 30, 2022
ce1b6cc
added execution index to redis
Apr 13, 2022
e04d90f
add apparatus to record call
Apr 13, 2022
d4e8518
successful response case
Apr 13, 2022
a7b8a04
added code to record successful response
Apr 13, 2022
27f32e8
added exception stuff to redis
Apr 19, 2022
9cced1c
added certain redis exceptions to possible faults
Apr 20, 2022
1945ffb
fixed the exception code, should be working now
Apr 27, 2022
4c4211c
forgot to add default-analysis.json
Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions default-analysis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,20 @@
}
]
},
"python.redis": {
"pattern": "redis\\.execute\\_command",
"exceptions": [
{
"name": "redis.exceptions.ConnectionError"
},
{
"name": "redis.exceptions.TimeoutError"
},
{
"name": "redis.exceptions.ResponseError"
}
]
},
"http": {
"pattern": "(((requests\\.(get|put|post|head))|(WebClient\\.(GET|PUT|POST|HEAD))))",
"errors": [
Expand Down
19 changes: 18 additions & 1 deletion filibuster/analysis/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,21 @@ def java_header_to_status_code(constant):
print("Found constant with no match: " + constant)
raise Exception("Analysis failed: unknown java header constant.")

def add_python_redis_exceptions():
# Setup.
instrumentation['python.redis'] = {}
instrumentation['python.redis']['pattern'] = "redis\\.execute\\_command"
instrumentation['python.redis']['exceptions'] = []

# Base exceptions.
# ConnectionError raised when the redis-server has disconnected
instrumentation['python.redis']['exceptions'].append(
{'name': 'redis.exceptions.ConnectionError'})
instrumentation['python.redis']['exceptions'].append(
{'name': 'redis.exceptions.TimeoutError'})
# ResponseError raised when set operations are used on a key whose value is not a set
instrumentation['python.redis']['exceptions'].append(
{'name': 'redis.exceptions.ResponseError'})

def exception_to_status_code(exception):
if exception == "Forbidden":
Expand Down Expand Up @@ -330,6 +345,8 @@ def analyze_services_directory(output, directory):
# Add Java grpc callsite exceptions.
add_java_grpc_exceptions()

add_python_redis_exceptions()

##################################################################################################################
# Fill out placeholder information for parsable file.
##################################################################################################################
Expand All @@ -340,7 +357,7 @@ def analyze_services_directory(output, directory):

if 'grpc' not in instrumentation:
instrumentation['grpc'] = {}
instrumentation['grpc']['pattern'] = "((grpc\\.insecure\_channel)|(.*Service/.*))"
instrumentation['grpc']['pattern'] = "((grpc\\.insecure\\_channel)|(.*Service/.*))"

if 'errors' not in instrumentation['http']:
instrumentation['http']['errors'] = []
Expand Down
Loading