This repository was archived by the owner on Aug 4, 2020. It is now read-only.
MGMT-1609 Container image migration from Ubuntu based OS to CentOS#495
Open
jparrill wants to merge 4 commits into
Open
MGMT-1609 Container image migration from Ubuntu based OS to CentOS#495jparrill wants to merge 4 commits into
jparrill wants to merge 4 commits into
Conversation
jparrill
force-pushed
the
rfe/revamp_docker_build
branch
6 times, most recently
from
d2012ef to
1c9921b
Compare
romfreiman
reviewed
Jul 29, 2020
romfreiman
reviewed
Jul 29, 2020
jparrill
force-pushed
the
rfe/revamp_docker_build
branch
6 times, most recently
from
3970510 to
5abd7d0
Compare
jparrill
force-pushed
the
rfe/revamp_docker_build
branch
from
5abd7d0 to
1ea9827
Compare
jparrill
force-pushed
the
rfe/revamp_docker_build
branch
from
1ea9827 to
bdeea33
Compare
Collaborator
Author
|
Don't merge it yet, I still need to modify the Dockerfile in order to meet the openshift/release needs and this involves to use UBI or CentOS as BaseOS on FROM field. For both I need to validate the right repositories |
jparrill
changed the title
jparrill
force-pushed
the
rfe/revamp_docker_build
branch
from
eb68d80 to
4aa99c8
Compare
djzager
reviewed
Jul 31, 2020
| @@ -1,15 +1,35 @@ | |||
| FROM golang:1.14.3 | |||
| FROM centos:7 | |||
There was a problem hiding this comment.
My contention would be that ubi (and ubi8 for that matter) would be the best choice to use upstream as it would most closely resemble d/s builds.
Suggested change
| FROM centos:7 | |
| FROM registry.access.redhat.com/ubi8/ubi-minimal:latest |
There was a problem hiding this comment.
But aren't you able to override the FROM for the purposes of prow builds?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions:
CE=podman make unit-test