This repository was archived by the owner on Aug 4, 2020. It is now read-only.
MGMT-1443 Wait for dummy job to finish pre proceeding#375
Open
oshercc wants to merge 1 commit into
Open
Conversation
filanov
reviewed
Jul 8, 2020
| if err := jobApi.Create(context.Background(), b.createImageJob(jobName, imgName, "Dummy")); err != nil { | ||
| log.WithError(err).Errorf("failed to generate dummy ISO image") | ||
| } | ||
| if err := b.job.Monitor(context.Background(), jobName, b.Namespace); err != nil { |
Owner
There was a problem hiding this comment.
Not sure it will help. because K8S will think that the service is operational and the subsystem will fail because the service will not reply to API
Owner
There was a problem hiding this comment.
We have no problem that Generate iso API will take a long time. this part was only a hack to help in the deployment and this will help in system environment but not in the CI.
Owner
|
suggesting to add a script that will wait for the job to start running or complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.