Skip to content

Demo/merchant onboarding validation - #42

Merged
fikrilal merged 2 commits into
mainfrom
demo/merchant-onboarding-validation
Sep 28, 2026
Merged

fikrilal merged 2 commits into
mainfrom
demo/merchant-onboarding-validation

Conversation

@fikrilal

Copy link
Copy Markdown
Owner

Summary

Describe what changed and why.

Risk Class

  • low
  • medium
  • high

Risk notes:

  • Production impact areas touched (if any):
  • Why this risk class was selected:

Acceptance Criteria

Checks Run

List exact commands and outcomes.

dart run mobile_core_kit_cli:mobilekit verify --profile full --env dev

Additional checks:

# examples:
# dart run mobile_core_kit_cli:mobilekit lint
# fvm flutter test
# dart run mobile_core_kit_cli:mobilekit codegen verify
# dart run mobile_core_kit_cli:mobilekit project-map verify

Hosted checks:

  • CI Risk passed
  • CI Full passed
  • CI Runtime passed or was intentionally skipped by classification
  • CI Governance passed
  • Stable CI Required aggregate passed

Evidence

  • Tests added/updated where behavior changed
  • Screenshots/video attached (UI changes)
  • Logs/error traces attached (runtime or failure-path changes)
  • Mobile runtime evidence attached for medium/high UI/runtime PRs (see docs/engineering/harness/mobile_runtime_harness.md)
  • Runtime evidence fingerprint matches the final reviewed candidate
  • No speculative refactor mixed into this PR
  • Handoff used fresh action-specific evidence and explicit publication authority
  • No force push, merge, deployment, signing, migration, or release was performed by the harness

Links/artifacts:

Runtime evidence details (if applicable):

  • Task fingerprint:
  • Device identifier hash:
  • Flavor:
  • Registered oracle results:
  • Evidence artifact paths:

Safety And Rollback

  • Potential failure mode:
  • Rollback strategy:
  • Follow-up required after merge (if any):

Reviewer Focus

Point reviewers to the highest-risk files/decisions:

Gradle 9.3.1, Android Gradle Plugin 9.1.0, and Kotlin 2.4.0 are the
versions that template ships. The previous floors only cleared the hard
minimum and still warned. Built-in Kotlin stays off because the current
Firebase plugins still apply the Kotlin Gradle plugin.
Flutter 3.47 and the Android AGP 9 guide both say to stop applying
kotlin-android in the app and set android.builtInKotlin=true.
android.newDsl stays false because Flutter has not finished that migration.
@fikrilal
fikrilal merged commit 6e86ad3 into main Sep 28, 2026
8 checks passed
@fikrilal
fikrilal deleted the demo/merchant-onboarding-validation branch September 29, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant