Skip to content

FX list: drag along the right edge to hop to top/bottom quickly (like dragging a scroll bar) - #3

Open
booherbg wants to merge 1 commit into
figamore:mainfrom
booherbg:feat/fx-scrub-strip
Open

FX list: drag along the right edge to hop to top/bottom quickly (like dragging a scroll bar)#3
booherbg wants to merge 1 commit into
figamore:mainfrom
booherbg:feat/fx-scrub-strip

Conversation

@booherbg

@booherbg booherbg commented Aug 15, 2026

Copy link
Copy Markdown

Summary

The effect list is ~190 rows, and LVGL 8 scrollbars are display-only, so getting from one end to the other is dozens of flings. This adds a scrub strip: press within 18 px of the list's right edge (where the scrollbar is drawn) and drag, and the list position tracks the finger over the whole scroll range — the same gesture as dragging a phone's scroll indicator.

  • A press in the strip without movement is still a normal tap, so the gear column keeps working.
  • The table's release-time cell click is suppressed after a scrub, so ending a drag over a row doesn't select that effect.
  • Normal drag-to-scroll and fling anywhere else in the list are unchanged.

Implementation is a small event handler (onScrubStrip / attachScrubStrip) in src/ui/tabs.cpp; the FX table is the only user for now, but it works for any scrollable object.

Testing

  • pio run -e esp32-cyd: builds, flash 96.9 % (+~1 KB).
  • pio run -e macos && program --selftest: ALL PASS.
  • Bench-tested on a capacitive CYD (JC2432W328C): a top-to-bottom drag on the right edge lands on the last effect; taps on gears and rows behave as before.

LVGL 8 scrollbars are display-only, and the ~190-row effect list is dozens
of flings from end to end. Pressing within 18 px of the list's right edge
and dragging now maps the finger's position onto the full scroll range,
like dragging a phone's scroll indicator. A press there without movement is
still a normal tap, so the gear column keeps working, and the table's
release-time cell click is suppressed after a scrub.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 850ff0c3-00e8-43fb-86d5-e47212f55925

📥 Commits

Reviewing files that changed from the base of the PR and between e56eaf4 and 67c0225.

📒 Files selected for processing (1)
  • src/ui/tabs.cpp

📝 Walkthrough

Walkthrough

The effects table adds a right-edge scrub strip. Dragging in the strip maps pointer position to the full scroll range. Short taps retain normal table-click behavior, while scrub gestures suppress effect activation.

Changes

Effects table scrub scrolling

Layer / File(s) Summary
Scrub gesture handling and table wiring
src/ui/tabs.cpp
The effects table handles right-edge drag gestures, maps pointer position to scroll offset, restores native scrolling on release, and suppresses clicks after scrubbing. FX tab construction attaches the handlers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 67c02

The change adds right-edge list scrubbing while preserving tap and normal scrolling behavior; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: figamore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: dragging along the FX list edge quickly moves through the list.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@booherbg booherbg changed the title FX list: drag along the right edge to scrub the whole list FX list: drag along the right edge to hop to top/bottom quickly (like dragging a scroll bar) Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant