Conversation
The shutdown countdown is the only user of lv_font_montserrat_48, which adds ~97KB to that env. The env last built at v1.2.1 (96.9% of the 1.69MiB OTA slot); the app growth in v1.2.2 pushed it to 102.3% and it has failed to build since. CI only compiles esp32-cyd, so the breakage went unnoticed. Gate the 48px font behind WLED_SCREEN_WIDTH >= 480 like montserrat_24/28 and fall back to montserrat_20 for the countdown on small screens. esp32-cyd-capacitive-ip5306-shutdown: 102.4% -> 96.9% of app slot; esp32-cyd unchanged in size; jc8048w550c/jc4880p443/macos still build and keep the 48px font where enabled.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe 48-point Montserrat font is now limited to screens at least 480 pixels wide. The shutdown countdown label selects that font when available and otherwise uses the 20-point fallback font. ChangesConditional font configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change removes an unused large font from small-screen builds while preserving the larger countdown font on supported displays; the reported builds pass and no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Found this while testing an unrelated power button issue - feel free to delete if not helpful. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
pio run -e esp32-cyd-capacitive-ip5306-shutdownfails on current main:The shutdown countdown label is the only reference to
lv_font_montserrat_48, which costs ~97KB of flash in this env alone. Build history of the env:v1.2.2 grew the app by ~96KB, which consumed the env's remaining headroom. CI only builds
esp32-cyd, so the breakage was not visible there.Fix: gate
LV_FONT_MONTSERRAT_48behindWLED_SCREEN_WIDTH >= 480(same pattern already used for montserrat_24/28) and fall back tolv_font_montserrat_20for the countdown on small screens.Verified locally:
esp32-cyd-capacitive-ip5306-shutdown: 102.4% → 96.9%esp32-cyd: unchanged size (1713705 bytes before and after; the font was already discarded by the linker as unreferenced in this env)jc8048w550c,jc4880p443,macossim: build, big screens keep the 48px countdown fontMight be worth adding this env to the release workflow's build matrix so it can't regress silently again.
Summary by CodeRabbit