perf: parallelize per-record feature extraction in ft fire -f#104
Merged
perf: parallelize per-record feature extraction in ft fire -f#104
Conversation
Switch the FireFeats construction from .iter() to .par_iter() in the -f (streaming feature-extraction) path. FireFeats::new is per-read and has no cross-record state, so rayon gives a straightforward speedup on wide chunks when -t is set above 1. Verified output is deterministic (md5 identical at 1 vs 8 threads on the test BAM) and cargo test still passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FireFeatsconstruction in the-f(streaming feature-extraction) path from.iter()to.par_iter().FireFeats::newis per-read with no cross-record state, so rayon gives a straightforward speedup on wide chunks when-t > 1.Test plan
cargo testpasses