Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 96.28% 96.26% -0.02%
==========================================
Files 48 48
Lines 1882 1872 -10
==========================================
- Hits 1812 1802 -10
Misses 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dagonite
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the caching layer for JWT (JSON Web Token) validation.
Security Impact
By shifting to real-time validation for every request, we mitigate the following threats:
Prevents Session Persistence via Misconfiguration: In certain cache configurations (specifically "sliding expiration"), the act of retrieving a token from the cache refreshes its Time-To-Live (TTL). This can inadvertently allow a session to remain active indefinitely as long as the user stays active, bypassing the intended hard expiry of the JWT.
Ensures Immediate Revocation: Currently, if a JWT is revoked (e.g., via a logout event or a security breach), a cached version of that token might remain valid until the cache entry expires. Removing the cache ensures that the system checks the current revocation status/blacklist on every request, providing immediate protection against compromised tokens.