Repository navigation
fix: detect postgraduate final-project courses by jenjang (BUG-003) - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the PISN graduation wizard so the "Kelengkapan Transkrip" check and the ENH-010 grade fill recognise postgraduate final-project courses.
Final-project detection is now selected per jenjang from
nama_program_studi, because course naming differs by program and the same name means different milestones at different levels:skripsi | tugas akhir | thesis | tesistesis | skripsi | tugas akhir | thesis | ujian hasil penelitian dan tutup | ujian tutupujian terbuka | promosiS2 Akuntansi uses
Ujian Tutupand S2 Manajemen usesUjian Hasil Penelitian dan Tutup; both are detected. S3'sUjian Tutupis an intermediate milestone and is deliberately not accepted there.The program name is persisted in wizard progress (
program_studi) sofinish()uses the same pattern; older progress records fall back toGetListMahasiswa.transcript_oknow requires a graded final-project course only; thechoosedmarker stays informational (BUG-001).UI/validation text changed from "skripsi/tugas akhir" to "karya akhir (skripsi/tesis/ujian akhir)". The Excel column
nilai_skripsiis unchanged for template compatibility.Related issues
Fixes #130
Checklist
php -lpasses on all modified PHP filesnpm run buildsucceeds and committed assets are up to datephp spark routesshows correct new routes (if routes changed)vendor/bin/php-cs-fixer fixpasses (no style violations)vendor/bin/phpunitis green (if tests exist)dd(),var_dump(),console.log(),print_r(),exit()csrf_field()esc()Screenshot (if applicable)
N/A — the only view change is wording on card 3 and the
transcript_oklabel; no layout change.Notes for reviewers
Deviation from the proposal in #130. The issue proposed one global pattern including
ujian tutup. Live probing of the 37 supplied S2 Akuntansi NIMs showed thatUjian Tutupis the S2 Akuntansi final course, but S3 also usesUjian Tutupas an intermediate milestone beforeUjian Terbuka (Promosi). A global pattern would mark S3 students complete too early (e.g. 2023250001 hadUjian TutupA whileUjian Terbukawas still E; 2024150009 has onlyUjian TutupE). The pattern is therefore selected per jenjang.Verification (read-only, against live Neo Feeder data):
Ujian Tutup-only (2024150009) incomplete; S3 results-exam-only (2023250002) incomplete; S1Skripsi(202010087) complete.choosedstayedfalseon 58/58 sampled S2 Akuntansi final-project rows, confirming it must stay out of the gate.php-cs-fixer --dry-run: 0 of 93 files need changes; LF/no-BOM markdown checks clean.ARCHITECTURE.mdcarries pre-existing, unrelated Verifikasi IPK documentation edits in the working tree; only the transcript-check hunk is included in this PR.