🧪 [testing improvement description] Add tests for is_overlay_file and improve extension matching#140
Conversation
… improve extension matching
🎯 **What:** The testing gap addressed was the lack of comprehensive tests for `is_overlay_file` logic in `src/utils/yaml.rs`. The logic also only supported `.yaml` extensions and not `.yml`.
📊 **Coverage:** What scenarios are now tested:
- Exact profile matches (e.g., `role.prod.yaml` with `Some("prod")`)
- Generic overlay matches (e.g., `client.test.yaml` with `Some("prod")`)
- No profile matches (e.g., `my.resource.yaml` with `None`)
- Non-overlays (e.g., `role.yaml`, `.hidden.yaml`, missing extensions, single dots).
- Full support for both `.yaml` and `.yml` extensions.
✨ **Result:** The improvement in test coverage provides robust validation for overlay file matching logic. Furthermore, the updated extension logic now cleanly handles `.yml` alongside `.yaml`, and ignores hidden files (like `.hidden.yaml`).
Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 92.54% 92.55% +0.01%
==========================================
Files 27 27
Lines 2227 2231 +4
==========================================
+ Hits 2061 2065 +4
Misses 166 166 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
🧪 [testing improvement description] Add tests for is_overlay_file and improve extension matching
🎯 What: The testing gap addressed was the lack of comprehensive tests for
is_overlay_filelogic insrc/utils/yaml.rs. The logic also only supported.yamlextensions and not.yml.📊 Coverage: What scenarios are now tested:
role.prod.yamlwithSome("prod"))client.test.yamlwithSome("prod"))my.resource.yamlwithNone)role.yaml,.hidden.yaml, missing extensions, single dots)..yamland.ymlextensions.✨ Result: The improvement in test coverage provides robust validation for overlay file matching logic. Furthermore, the updated extension logic now cleanly handles
.ymlalongside.yaml, and ignores hidden files (like.hidden.yaml).PR created automatically by Jules for task 16228419180396298649 started by @ffalcinelli