Skip to content

🧪 [testing improvement description] Add tests for is_overlay_file and improve extension matching#140

Merged
ffalcinelli merged 3 commits into
mainfrom
testing-improvement-is-overlay-file-16228419180396298649
Jul 2, 2026
Merged

🧪 [testing improvement description] Add tests for is_overlay_file and improve extension matching#140
ffalcinelli merged 3 commits into
mainfrom
testing-improvement-is-overlay-file-16228419180396298649

Conversation

@ffalcinelli

Copy link
Copy Markdown
Owner

🧪 [testing improvement description] Add tests for is_overlay_file and improve extension matching

🎯 What: The testing gap addressed was the lack of comprehensive tests for is_overlay_file logic in src/utils/yaml.rs. The logic also only supported .yaml extensions and not .yml.

📊 Coverage: What scenarios are now tested:

  • Exact profile matches (e.g., role.prod.yaml with Some("prod"))
  • Generic overlay matches (e.g., client.test.yaml with Some("prod"))
  • No profile matches (e.g., my.resource.yaml with None)
  • Non-overlays (e.g., role.yaml, .hidden.yaml, missing extensions, single dots).
  • Full support for both .yaml and .yml extensions.

Result: The improvement in test coverage provides robust validation for overlay file matching logic. Furthermore, the updated extension logic now cleanly handles .yml alongside .yaml, and ignores hidden files (like .hidden.yaml).


PR created automatically by Jules for task 16228419180396298649 started by @ffalcinelli

… improve extension matching

🎯 **What:** The testing gap addressed was the lack of comprehensive tests for `is_overlay_file` logic in `src/utils/yaml.rs`. The logic also only supported `.yaml` extensions and not `.yml`.

📊 **Coverage:** What scenarios are now tested:
- Exact profile matches (e.g., `role.prod.yaml` with `Some("prod")`)
- Generic overlay matches (e.g., `client.test.yaml` with `Some("prod")`)
- No profile matches (e.g., `my.resource.yaml` with `None`)
- Non-overlays (e.g., `role.yaml`, `.hidden.yaml`, missing extensions, single dots).
- Full support for both `.yaml` and `.yml` extensions.

✨ **Result:** The improvement in test coverage provides robust validation for overlay file matching logic. Furthermore, the updated extension logic now cleanly handles `.yml` alongside `.yaml`, and ignores hidden files (like `.hidden.yaml`).

Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.55%. Comparing base (3d02386) to head (91eedd9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   92.54%   92.55%   +0.01%     
==========================================
  Files          27       27              
  Lines        2227     2231       +4     
==========================================
+ Hits         2061     2065       +4     
  Misses        166      166              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

google-labs-jules Bot and others added 2 commits June 25, 2026 17:46
Co-authored-by: ffalcinelli <1167082+ffalcinelli@users.noreply.github.com>
@ffalcinelli ffalcinelli merged commit a07ebf2 into main Jul 2, 2026
9 checks passed
@ffalcinelli ffalcinelli deleted the testing-improvement-is-overlay-file-16228419180396298649 branch July 2, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant