STEVE!!! by wrjones104 · Pull Request #155 · ff6wc/WorldsCollide

wrjones104 · 2026-06-04T18:33:29Z

Add STEVE
EVERYTHING IS AND ALWAYS WILL BE STEVE
Changes all item, character, skill, magic, enemy, etc. names to "STEVE" or the string given by the user

…agation

… propagation

gemini-code-assist

Code Review

This pull request introduces a "Steveify" feature that allows renaming characters, items, espers, magic, enemies, and other game elements to a specified name (defaulting to "Steve"). The changes span across command-line argument parsing and various data-handling modules to apply the renaming logic. The review comments point out a critical NameError in args/graphics.py due to an undefined variable who_there, and a performance optimization opportunity in data/data.py to move constant string conversion and padding logic outside of a loop.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

- Improved validation of `steveify` argument. - Updated `Espers.get_name` to use internal data directly. - Enhanced `Lores.mod` method for dynamic name modification based on regex.

wrjones104 · 2026-06-05T16:37:58Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new 'steveify' feature (--steveify / -steve) that renames various game entities—including characters, items, espers, spells, enemies, dances, lores, magiteks, and swdtechs—to a specified name (defaulting to 'Steve'). The implementation updates command-line argument parsing, flag generation, and name-replacement logic across multiple data modules. Feedback on the changes suggests wrapping the -steve flag value in double quotes to handle names with spaces correctly, and using the standard get_name() method on the Esper class instead of accessing the raw .name attribute directly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

wrjones104 · 2026-06-23T17:51:10Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces the "Steveify" feature, allowing players to rename characters, items, espers, magic, enemies, and other elements to a specified name (defaulting to "Steve"). The feedback suggests increasing the global truncation limit of the name from 6 to 12 characters to support categories with longer name limits, while explicitly truncating the name to category-specific lengths in individual modules (such as characters, dances, enemies, espers, magiteks, and swdtechs) to prevent potential buffer overflows or ROM write issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-23T17:53:00Z

+    if args.steveify is not None:
+        args.names = [args.steveify] * Characters.CHARACTER_COUNT


Since args.steveify is no longer truncated to 6 characters globally, we should explicitly truncate it to Characters.NAME_SIZE (6) when assigning to args.names to ensure character names do not exceed their limit.

Suggested change

if args.steveify is not None:

args.names = [args.steveify] * Characters.CHARACTER_COUNT

if args.steveify is not None:

args.names = [args.steveify[:Characters.NAME_SIZE]] * Characters.CHARACTER_COUNT

gemini-code-assist · 2026-06-23T17:53:00Z

+        if self.args.steveify:
+            for character in self.characters:
+                character.name = self.args.steveify


Explicitly truncate self.args.steveify to self.NAME_SIZE (6) to prevent potential buffer overflow or write issues if a longer custom name is provided.

Suggested change

if self.args.steveify:

for character in self.characters:

character.name = self.args.steveify

if self.args.steveify:

for character in self.characters:

character.name = self.args.steveify[:self.NAME_SIZE]

gemini-code-assist · 2026-06-23T17:53:00Z

+        if self.args.steveify:
+            for dance in self.dances:
+                dance.name = self.args.steveify


Explicitly truncate self.args.steveify to self.NAME_SIZE (12) to prevent potential buffer overflow or write issues if a longer custom name is provided.

Suggested change

if self.args.steveify:

for dance in self.dances:

dance.name = self.args.steveify

if self.args.steveify:

for dance in self.dances:

dance.name = self.args.steveify[:self.NAME_SIZE]

gemini-code-assist · 2026-06-23T17:53:00Z

+        if self.args.steveify:
+            return self.args.steveify


Ensure get_name returns the truncated name (up to self.NAME_SIZE characters) to remain consistent with what is actually written to the ROM.

Suggested change

if self.args.steveify:

return self.args.steveify

if self.args.steveify:

return self.args.steveify[:self.NAME_SIZE]

gemini-code-assist · 2026-06-23T17:53:00Z

+        if self.args.steveify:
+            for enemy in self.enemies:
+                if enemy.name:
+                    enemy.name = self.args.steveify
+                if enemy.special_name:
+                    enemy.special_name = self.args.steveify


Explicitly truncate self.args.steveify to self.NAME_SIZE (10) and self.SPECIAL_NAMES_SIZE (10) respectively to prevent potential buffer overflow or write issues if a longer custom name is provided.

Suggested change

if self.args.steveify:

for enemy in self.enemies:

if enemy.name:

enemy.name = self.args.steveify

if enemy.special_name:

enemy.special_name = self.args.steveify

if self.args.steveify:

for enemy in self.enemies:

if enemy.name:

enemy.name = self.args.steveify[:self.NAME_SIZE]

if enemy.special_name:

enemy.special_name = self.args.steveify[:self.SPECIAL_NAMES_SIZE]

gemini-code-assist · 2026-06-23T17:53:00Z

+        if self.args.steveify:
+            for esper in self.espers:
+                esper.name = self.args.steveify


Explicitly truncate self.args.steveify to self.NAME_SIZE (8) to prevent potential buffer overflow or write issues if a longer custom name is provided.

Suggested change

if self.args.steveify:

for esper in self.espers:

esper.name = self.args.steveify

if self.args.steveify:

for esper in self.espers:

esper.name = self.args.steveify[:self.NAME_SIZE]

gemini-code-assist · 2026-06-23T17:53:00Z

+        if self.args.steveify:
+            for magitek in self.magiteks:
+                magitek.name = self.args.steveify


Explicitly truncate self.args.steveify to self.NAME_SIZE (10) to prevent potential buffer overflow or write issues if a longer custom name is provided.

Suggested change

if self.args.steveify:

for magitek in self.magiteks:

magitek.name = self.args.steveify

if self.args.steveify:

for magitek in self.magiteks:

magitek.name = self.args.steveify[:self.NAME_SIZE]

gemini-code-assist · 2026-06-23T17:53:01Z

+        if self.args.steveify:
+            for swdtech in self.swdtechs:
+                swdtech.name = self.args.steveify


Explicitly truncate self.args.steveify to SwdTech.NAME_SIZE to prevent potential buffer overflow or write issues if a longer custom name is provided.

Suggested change

if self.args.steveify:

for swdtech in self.swdtechs:

swdtech.name = self.args.steveify

if self.args.steveify:

for swdtech in self.swdtechs:

swdtech.name = self.args.steveify[:SwdTech.NAME_SIZE]

wrjones104 added 5 commits June 4, 2026 14:29

STEVE!

14aad9c

changes based on PR comments

0d80204

Fix graphics menu alignment and visual sprite loader hook Z flag prop…

9dc7fbb

…agation

Fix Steveify flags menu display of None and support dynamic Arguments…

a29d13b

… propagation

Change default Steveify name override to all-caps STEVE

46bc2c6

wrjones104 requested review from BriGuy7727, bootherunner and ff6wc as code owners June 4, 2026 18:33

gemini-code-assist Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread args/graphics.py Outdated

Comment thread data/data.py

wrjones104 and others added 4 commits June 4, 2026 15:56

Remove "who_there" reference

119e36c

Update data/data.py

17a5e0f

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update data/items.py

1523500

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

fix steveify logic and update name handling in espers and lores

c4f3ad5

- Improved validation of `steveify` argument. - Updated `Espers.get_name` to use internal data directly. - Enhanced `Lores.mod` method for dynamic name modification based on regex.

gemini-code-assist Bot reviewed Jun 5, 2026

View reviewed changes

Comment thread data/espers.py Outdated

Comment thread args/graphics.py Outdated

wrjones104 and others added 2 commits June 23, 2026 13:50

Update args/graphics.py

77bde48

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update data/espers.py

0ca6b17

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

gemini-code-assist Bot reviewed Jun 23, 2026

View reviewed changes

wrjones104 merged commit 90b31b2 into ff6wc:dev Jun 23, 2026
6 checks passed

		if args.steveify is not None:
		args.names = [args.steveify] * Characters.CHARACTER_COUNT

Conversation

wrjones104 commented Jun 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

wrjones104 commented Jun 5, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

wrjones104 commented Jun 23, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant