Adding Flag Shuffling Bosses by World#137
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature to shuffle boss battles restricted by world (World of Balance and World of Ruin) via the -bbws flag. It adds the necessary command-line arguments, separates boss packs into world-specific pools, and implements the world-shuffling logic. The feedback points out a redundant safety check for Phunbaba 3 in the World of Balance boss list, which can be safely removed since the pools are kept strictly separate.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # I don't think this is needed because phunbaba 3 should be in wor but just in case | ||
| self.phunbaba3_safety_check(wob_bosses_to_replace) |
There was a problem hiding this comment.
The safety check for Phunbaba 3 is redundant and unreachable under world shuffle. Number 128 is a World of Balance boss, whereas Phunbaba 3 is a World of Ruin boss. Since the two pools are kept strictly separate during world shuffle, Phunbaba 3 can never be assigned to the Number 128 location. We can safely remove this redundant call and comment to keep the codebase clean and maintainable.
2 participants
Adding flag -bbws which shuffles bosses in separate pools between the World of Ruin and the World of Balance based on the location the boss spot is in.