Skip to content

Fix potential vulnerability in CI workflow #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joewallwork wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix potential vulnerability in CI workflow #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc74cc
Fix vulnerability in cloud benchmarking workflow
joewallwork Mar 31, 2025
46c53ce
Persist credentials when checking out
joewallwork Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/cloud-benchmarking-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
persist-credentials: false
- name: Set Initial Variables
# By default we use 1Hr benchmarks
run: |
Expand All @@ -43,8 +44,8 @@ jobs:
# conditionally overwrite variables if a tag was the triggering event
- name: Reset Initial Variables for pull request
run: |
echo "GITHUB_SHA_SHORT=`echo ${{ github.event.pull_request.head.sha }} | cut -c1-7`" >> $GITHUB_ENV
echo "COMMIT_NAME=`echo ${{ github.event.pull_request.head.sha }} | cut -c1-7`" >> $GITHUB_ENV
echo "GITHUB_SHA_SHORT=${{ github.event.pull_request.head.sha | substr(0, 7) }}" >> $GITHUB_ENV
echo "COMMIT_NAME=${{ github.event.pull_request.head.sha | substr(0, 7) }}" >> $GITHUB_ENV
if: github.event_name == 'pull_request'
- name: Reset Variables For Tags
# We do a 1Month benchmark for tags
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/gcclassic-compile-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:

steps:
- name: Checkout code
with:
persist-credentials: false
uses: actions/checkout@v4

- name: Install dependencies
Expand Down