Repository navigation
Recover lost isolated browser daemons during CI startup - #640
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main Web startup regression run failed after two successful scenarios when agent-browser returned success for session info with runtime=null. Reading runtime.pageCount then crashed the harness before the next UI checks. The following diagnostics started a replacement daemon on about:blank.
Recover this startup-only loss by closing the task-owned session and opening a fresh isolated session, bounded to three attempts. Keep the single-page isolation assertion strict and propagate navigation/UI failures immediately. Apply the same isolation gate to the catalogue-login scenario. No production application code or browser version changes.
Validation: the actual automation/test_web_startup.sh command passes all 105 Node tests and all seven isolated Chromium scenarios. Five new regression cases cover missing runtime recovery, healthy startup, bounded persistent loss, wrong page isolation, and navigation failures. Existing CI failure: https://github.com/festappnet/festapp/actions/runs/40472442125 . Authoritative main fetched before publication at a626e38; no intervening changes.