test: record doctor FTS feasibility - #76
Merged
Merged
Conversation
test: measure doctor FTS feasibility
ferueda
marked this pull request as ready for review
July 28, 2026 03:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The proposed bounded-memory doctor design depended on document-filtered
fts5vocabreads being cheap. PR #77 was stacked on this PR and merged into its branch, so this PR now contains both the original planning gate and the completed measurement.The measurement found that 41 production-shaped intervals made total work 3.80× slower and grouped term-summary work 6.82× slower on the large generated cohort. The query-plan and scaling evidence is consistent with repeated whole-vocabulary traversal. That makes the proposed interval strategy unsuitable for production doctor.
Impact
No production
src/behavior, public CLI contract, schema, provider access, or retained-library state changes.pnpm measure:doctoris an opt-in contributor command using generated data. It records exact equality, immutable-file, privacy, cleanup, timing, RSS, and query-plan evidence. The durable research note records the rejected approach so it is not repeated.The successor plan evaluates a single-pass actual/expected comparison. It remains a feasibility gate and does not claim bounded total memory or authorize production changes.
Verification
pnpm measure:doctorcompleted three generated runs with every hard correctness gate passingpnpm test test/doctor-measurement.test.tspnpm check