Implement BitIdx → BitEnd conversion#252
Open
mina86 wants to merge 1 commit intoferrilab:mainfrom
Open
Conversation
Contributor
|
very much a nitpick: typo in the commit comment |
Since BitIdx’s inner value is within the domain of BigEnd, it’s possible to infallibly convert the former into the latter. Alas, no function facilitating this exist and conversion through u8 is required. Introduce `From<BitIdx<R>> for BitEnd<R>` implementation which provides such feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since BitIdx’s inner value is always withing the domain of BigEnd type
it is theoretically possible to convert infallibly the former into the
latter. Alas, no such facility exist and instead conversion through
u8 is required.
Introduce
From<BitIdx<R>> for BitEnd<R>implementation whichprovides that feature.