[NEW] - PokeCard component#1
Open
fernandaMadin wants to merge 1 commit into
Open
Conversation
wdonet
approved these changes
Jan 25, 2021
| return ( | ||
| <div className="App"> | ||
| <h1>Welcome to your second mini challenge!</h1> | ||
| <PokeCard /> |
There was a problem hiding this comment.
It would be better to inject mock data here instead of inside the component.
Advantages:
- Improve your Unit testing
- Avoid DRY when using the component in different parts of your app
|
|
||
| function PokeCard() { | ||
| return ( | ||
| <div class="container"> |
There was a problem hiding this comment.
good! you're using class names for styling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.