GCC 15 compatibility fix + USAGE.md#22
Open
rsperry79 wants to merge 2 commits into
Open
Conversation
- Drop -Wpedantic (triggers new pedantic errors in GCC 15) - Add -Wno-implicit-function-declaration to CFLAGS - Add nisrom_finders.c to all Makefile targets that use nislib_shtools.c (nislib_shtools.c calls check_ivt() which is defined in nisrom_finders.c) - Add missing #include "nisrom_finders.h" in nislib_shtools.c, nisrom.c, nisrom_finders.c (GCC 15 rejects implicit function declarations in C99) - Fix md5/md5.c: use local include "md5.h" instead of system <md5.h>
Adds a USAGE.md covering all 10 nissutils CLI tools: - nisrom: ROM identification, checksum fix, EEPROM read, K-value - nisguess / nisguess2: s27k/s36k security key derivation - nisckfix1 / nisckfix2: alternate checksum correction variants - nisdec1 / nisenc1: ROM decode/encode - keyset_lookup.py: ECUID-to-keyset DB lookup - keyset_add.py: adding new keysets Covers: synopsis, key options, typical workflows, output interpretation, and AI-agent notes for common pitfalls in each tool.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two independent improvements:
GCC 15 rejects implicit function declarations as errors under C99. Without this fix the build fails on any GCC 15 system:
Drop -Wpedantic from CFLAGS (triggers new pedantic errors in GCC 15)
Add -Wno-implicit-function-declaration to CFLAGS
Add nisrom_finders.c to all Makefile targets that link nislib_shtools.c (nisckfix1, nisckfix2, nisdec1, nisenc1, nisguess, nisguess2, unpackdat, test_romdb) — nislib_shtools.c calls check_ivt() which is defined in nisrom_finders.c
Add missing #include "nisrom_finders.h" in nislib_shtools.c, nisrom.c, nisrom_finders.c
Fix md5/md5.c: use local "md5.h" instead of system <md5.h>
Adds a reference document covering all 10 CLI tools with synopsis, options, examples, and AI-agent notes for common pitfalls. Covers nisrom, nisckfix1/2, nisdec1/nisenc1, nisguess/2, findcallargs, findrefs, unpackdat, the romdb/ keyset database, and ghidra_helpers/nissan_load.py.