Skip to content

Add tests for GetGoalsForUser route#230

Open
uttekaraaru wants to merge 3 commits into
fencer-so:mainfrom
uttekaraaru:main
Open

Add tests for GetGoalsForUser route#230
uttekaraaru wants to merge 3 commits into
fencer-so:mainfrom
uttekaraaru:main

Conversation

@uttekaraaru

Copy link
Copy Markdown

This pull request adds unit test coverage for the GetGoalsForUser endpoint in GoalController.

Changes made:

  • Added a new test for retrieving goals for a specific user.
  • Verified returned goal data including IDs and names.
  • Used fake services and test collections to simulate API behavior.
  • Improved backend test coverage.

Added an optional Icon property to the Goal model.
Refactor GetForUser test to include goal and user setup.
@gitguardian

gitguardian Bot commented Jun 15, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials 7d9781f CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant