Skip to content

chore(tokens): drop dead sidebar brand tokens, sync DESIGN.md active state #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qqqqqf-q merged 2 commits into from
Jul 31, 2026
Merged

chore(tokens): drop dead sidebar brand tokens, sync DESIGN.md active state #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a46dc0
chore(tokens): drop dead sidebar brand tokens, sync DESIGN.md active …
qqqqqf-q Jul 31, 2026
d470cfb
chore(showcase): drop --sidebar-primary from the brand color catalog
qqqqqf-q Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESIGN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ The system employs a **bimodal elevation strategy**:
- **Breadcrumb**: Minimalist. 14px icons, 4px-6px gaps. Active page is `text-foreground font-normal`, inactive is `text-muted-foreground`.
- **Sidebar**:
- Container uses `primary-foreground` background.
- Active items use `accent` background with a 2px `primary` left border indicator.
- Active items use a `sidebar-accent` background and `font-medium` weight (no colored indicator bar or ring).

### Items

Expand Down
2 changes: 1 addition & 1 deletion showcase/lib/color-catalog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export const COLOR_SECTIONS: ColorSection[] = [
title: 'Brand',
titleZh: '品牌色',
families: [
rowsFamily(['--brand', '--brand-soft', '--brand-border', '--brand-hover', '--sidebar-primary']),
rowsFamily(['--brand', '--brand-soft', '--brand-border', '--brand-hover']),
],
},
{
Expand Down
13 changes: 0 additions & 13 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,12 +1105,9 @@
--chart-5: oklch(0.769 0.188 70.08);
--sidebar: var(--background);
--sidebar-foreground: oklch(0.21 0.004 95);
--sidebar-primary: oklch(0.55 0.22 290);
--sidebar-primary-foreground: oklch(0.985 0 0);
--sidebar-accent: var(--overlay-hover);
Comment on lines 1107 to 1108

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the deleted token from the local color catalog

After this removal, opening the showcase’s Foundations → Colors page still renders the Brand entry declared at showcase/lib/color-catalog.ts:109 for --sidebar-primary. Because the variable is now undefined, its bar has no background, its tooltip resolves to —, and clicking it copies a nonexistent token; the repository contract also still identifies this as a reserved token. Update the local catalog and contract in the same change, or retain the token.

AGENTS.md reference: AGENTS.md:L330-L335

Useful? React with 👍 / 👎.

--sidebar-accent-foreground: oklch(0.21 0.004 95);
--sidebar-border: oklch(0.905 0.0045 72);
--sidebar-ring: oklch(0.55 0.22 290);
--scrollbar-thumb: oklch(0 0 0 / 0.18);
--scrollbar-thumb-hover: oklch(0 0 0 / 0.32);
--primary: var(--brand);
Expand All @@ -1120,8 +1117,6 @@
--brand-soft: oklch(0.96 0.025 290);
--brand-border: oklch(0.84 0.08 290);
--brand-hover: oklch(0.49 0.23 290);
--sidebar-primary: var(--brand);
--sidebar-ring: var(--brand);
/* PRIMARY button ramp (charcoal high-emphasis CTA). rest → hover → press, each
step lighter (19 → 51 → 92 lighten). This is the default high-emphasis fill;
the scheme brand is reserved for variant="brand". */
Expand Down Expand Up @@ -1494,12 +1489,9 @@
--chart-5: oklch(0.645 0.246 16.439);
--sidebar: oklch(0.185 0 0);
--sidebar-foreground: oklch(0.90 0 0);
--sidebar-primary: oklch(0.62 0.22 290);
--sidebar-primary-foreground: oklch(0.985 0 0);
--sidebar-accent: var(--overlay-hover);
--sidebar-accent-foreground: oklch(0.86 0 0);
--sidebar-border: oklch(1 0 0 / 8%);
--sidebar-ring: oklch(0.62 0.22 290);
--scrollbar-thumb: oklch(1 0 0 / 0.14);
--scrollbar-thumb-hover: oklch(1 0 0 / 0.26);
--primary: var(--brand);
Expand All @@ -1509,8 +1501,6 @@
--brand-soft: oklch(0.30 0.07 290 / 0.45);
--brand-border: oklch(0.72 0.16 290 / 0.35);
--brand-hover: oklch(0.78 0.15 290);
--sidebar-primary: var(--brand);
--sidebar-ring: var(--brand);
/* Dark mode: the primary CTA inverts to a light fill (text-background gives it
dark text automatically), still lightening rest → hover → press. */
--btn-primary: oklch(0.976 0 0);
Expand Down Expand Up @@ -2021,12 +2011,9 @@

--color-sidebar: var(--sidebar);
--color-sidebar-foreground: var(--sidebar-foreground);
--color-sidebar-primary: var(--sidebar-primary);
--color-sidebar-primary-foreground: var(--sidebar-primary-foreground);
--color-sidebar-accent: var(--sidebar-accent);
--color-sidebar-accent-foreground: var(--sidebar-accent-foreground);
--color-sidebar-border: var(--sidebar-border);
--color-sidebar-ring: var(--sidebar-ring);
--color-brand: var(--brand);
--color-brand-foreground: var(--brand-foreground);
--color-brand-soft: var(--brand-soft);
Expand Down
Loading