fix(callout-banner): tone-preserving hover on clickable banners #12
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,9 @@ | |
| <component | ||
| :is="clickable ? 'button' : 'div'" | ||
| :type="clickable ? 'button' : undefined" | ||
| data-slot="callout-banner" | ||
| :data-tone="tone" | ||
| :data-clickable="clickable ? '' : undefined" | ||
| class="flex flex-col gap-3 rounded-menu-shell border px-4 py-3 text-left sm:flex-row sm:items-center" | ||
| :class="[toneClass, clickable ? interactiveClass : '']" | ||
| > | ||
|
|
@@ -68,19 +71,27 @@ const props = withDefaults(defineProps<{ | |
| }) | ||
|
|
||
| // Full literal class strings per tone — Tailwind scans source text, so a runtime | ||
| // concat would never be generated. Clickable hover uses the *-soft-hover tokens | ||
| // (utilities layer) so the wash is visible and stays in the same tone family. | ||
| const toneClass = computed(() => { | ||
| if (props.tone === 'destructive') { | ||
| const rest = 'border-destructive-border bg-destructive-soft' | ||
| return props.clickable | ||
| ? `${rest} transition-colors hover:bg-destructive-soft-hover hover:border-destructive-border-hover` | ||
|
There was a problem hiding this comment.
On every clickable-banner hover, this now deepens both the background and the border, stacking two simultaneous chrome changes where the design contract permits one layer to change in place. Preserve the tone by deepening only the soft fill and remove the AGENTS.md reference: AGENTS.md:L142-L151 Useful? React with 👍 / 👎. |
||
| : rest | ||
| } | ||
| const rest = 'border-warning-border bg-warning-soft' | ||
| return props.clickable | ||
| ? `${rest} transition-colors hover:bg-warning-soft-hover hover:border-warning-border-hover` | ||
| : rest | ||
| }) | ||
|
|
||
| const iconClass = computed(() => | ||
| props.tone === 'destructive' ? 'text-destructive' : 'text-warning-foreground', | ||
| ) | ||
|
|
||
| // When the whole banner is the affordance, hover stays in the same tone family | ||
| // (see [data-slot="callout-banner"] rules in style.css) — not hover:bg-accent, | ||
| // which replaced destructive/warning fills with neutral gray. | ||
| const interactiveClass = 'w-full cursor-pointer' | ||
| </script> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For every clickable banner, these
hover:*andtransition-colorsutilities put interaction chrome in the Vue utility layer, leaving the newdata-slot/data-toneattributes unused and preventing this state from being maintained through the library's central chrome contract. Move the tone-specific hover and transition rules intostyle.css, keyed by the added data attributes, rather than resolving the cascade conflict by bypassing the required ownership boundary.AGENTS.md reference: AGENTS.md:L112-L114
Useful? React with 👍 / 👎.