Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions apps/desktop/AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ menus, keyboard integration, cache invalidation, preload IPC, and the renderer
bootstrap.

Desktop does not start a local server, package database files, embed Qdrant, or
install a companion CLI. It may embed the `@memohai/runtime` SDK so the Electron
main process can connect this computer to the hosted server as a trusted Remote
Runtime. Use `MEMOH_DESKTOP_BASE_URL` to point the app at the target server. The
default dev target is `http://localhost:18080`.
install a companion CLI. It embeds the `@memohai/runtime` SDK plus exact
JavaScript-only ACP adapters so the Electron main process can connect this
computer to the hosted server as a trusted Remote Runtime. Native Codex and
Claude Code executables are user-installed and are never redistributed in the
Desktop package. Use `MEMOH_DESKTOP_BASE_URL` to point the app at the target
server. The default dev target is `http://localhost:18080`.

## Tech Stack

Expand Down Expand Up @@ -95,6 +97,7 @@ source aliases just to silence type errors.
- cache invalidation broadcast
- renderer `/api` proxy target via `MEMOH_DESKTOP_BASE_URL`
- encrypted Remote Runtime configuration and `RuntimeSession` lifecycle
- fixed ACP adapter discovery and local Codex/Claude CLI selection

The preload bridge is the only renderer API surface for Electron/main-process
behavior. Keep it small and typed in both `src/preload/index.ts` and
Expand Down Expand Up @@ -124,6 +127,13 @@ localhost policy, filesystem paths, and commands are owned by Main.
Do not add IPC for local database auth, project-folder picking, server lifecycle,
arbitrary filesystem/command access, or CLI installation.

`src/main/acp-adapters.ts` is the only Desktop adapter resolver. It passes
fixed Main-owned absolute paths to `RuntimeSession`, never to IPC. Both aliases
must be present: a descriptor when a local CLI is found, or `false`
to suppress ambient PATH fallback. macOS and Linux are supported; Windows must
keep both aliases disabled. Desktop and Runtime launch the local process but do
not own provider authentication or local Agent configuration.

## Renderer

`src/renderer/src/main.ts` creates the Vue app, installs the reused web plugins,
Expand Down Expand Up @@ -157,6 +167,14 @@ unpacked for the gRPC loader. Do not add server binaries, installed CLI
binaries, database files, provider templates, container runtimes, Qdrant, or
media runtimes to Desktop packaging.

Remote ACP packaging pins `@agentclientprotocol/codex-acp` and
`@agentclientprotocol/claude-agent-acp` exactly and leaves their JavaScript
dependency graph inside `app.asar`. The two optional platform-native agent
package families must remain excluded: users supply their own Codex and Claude
Code CLIs. Keep the `runAsNode` fuse enabled, the packaged Electron/ASAR smoke
hook green, adapter LICENSE files present, and `resources/THIRD_PARTY_NOTICES.md`
current.

`scripts/build.mjs` owns build-time environment loading and signing setup.
Process/CI values override `apps/desktop/.env`; it always passes
`--publish never`, so release workflows upload completed artifacts rather than
Expand Down
20 changes: 20 additions & 0 deletions apps/desktop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,26 @@ installers. Clone the repository and run the platform build command above, or
use a downstream distribution workflow that signs and publishes the generated
files.

### Remote ACP adapters

On macOS and Linux, Desktop can expose this computer as a Remote ACP Runtime.
The package includes exact JavaScript adapters (`codex-acp` 1.2.0 and
`claude-agent-acp` 0.66.0), executed with Electron's bundled Node.js 24. It does
not require a system Node/npm installation and does not redistribute either
provider's native CLI. Desktop discovers an independently installed `codex` or
`claude` executable and gives it to Runtime through a Main-process-only typed
descriptor. Windows does not advertise these bundled adapters in the first
release.

Adapter and native-agent paths stay in Electron Main and are never exposed to
the renderer or sent in the Runtime handshake. Remote ACP does not copy or
manage Codex/Claude credentials or configuration; the local tools own their own
setup.

Every package build runs an unpacked-app smoke test with the packaged Electron:
it checks Node.js 22+, exact adapter versions, and absence of optional native
agent packages.

### Build environment

| Variable | Purpose | GitHub setting |
Expand Down
14 changes: 14 additions & 0 deletions apps/desktop/electron-builder.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
appId: ai.memoh.desktop
productName: Memoh
copyright: Copyright © 2026 Memoh
afterPack: scripts/acp-packaging.mjs
afterSign: scripts/acp-packaging.mjs
electronFuses:
# Runtime-owned adapter bootstraps use packaged Electron as Node 24.
runAsNode: true
directories:
buildResources: build
output: dist
Expand All @@ -9,6 +14,10 @@ files:
- package.json
- resources/icon.png
- resources/tray-icon.png
# Native Codex / Claude Code executables are supplied by the user. Keep the
# fixed JavaScript adapters, but never redistribute their optional binaries.
- "!node_modules/@openai/codex-{darwin,linux,win32}-*{,/**/*}"
- "!node_modules/@anthropic-ai/claude-agent-sdk-{darwin,linux,win32}-*{,/**/*}"
- "!**/.vscode/*"
- "!src/*"
- "!scripts/*"
Expand Down Expand Up @@ -72,3 +81,8 @@ nsis:
npmRebuild: false
asarUnpack:
- node_modules/@memohai/runtime/dist/bridge.proto
extraResources:
- from: resources/THIRD_PARTY_NOTICES.md
to: THIRD_PARTY_NOTICES.md
- from: resources/licenses
to: licenses
4 changes: 3 additions & 1 deletion apps/desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@
"typecheck:node": "pnpm run prepare:runtime && tsc --noEmit -p tsconfig.node.json --composite false",
"typecheck:web": "vue-tsc --noEmit -p tsconfig.web.json --composite false",
"typecheck": "pnpm run typecheck:node && pnpm run typecheck:web",
"test:release": "vitest run src/shared/updates.test.ts src/main/external-links.test.ts && node --test scripts/build-env.test.mjs",
"test:release": "vitest run src/shared/updates.test.ts src/main/external-links.test.ts && node --test scripts/build-env.test.mjs scripts/acp-packaging.test.mjs",
"icons": "node scripts/build-icons.mjs"
},
"dependencies": {
"@agentclientprotocol/claude-agent-acp": "0.66.0",
"@agentclientprotocol/codex-acp": "1.2.0",
"@electron-toolkit/preload": "^3.0.1",
"@electron-toolkit/utils": "^4.0.0",
"@fontsource-variable/inter": "^5.2.8",
Expand Down
25 changes: 25 additions & 0 deletions apps/desktop/resources/THIRD_PARTY_NOTICES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Remote ACP third-party notices

Memoh Desktop includes these pinned JavaScript adapters:

- `@agentclientprotocol/codex-acp` 1.2.0 — Apache License 2.0
- `@agentclientprotocol/claude-agent-acp` 0.66.0 — Apache License 2.0

Their package license files are retained with the packaged modules. The
adapters' non-optional JavaScript dependencies are also included under their
respective licenses.

`@openai/codex` 0.147.0 is included only as the adapter's JavaScript wrapper;
its platform-native optional packages are excluded. It is Apache-2.0 licensed.
The release package includes the repository's Apache License 2.0 text, its
upstream NOTICE attribution for the 0.147.0 tag, and the npm package
metadata/README. The published npm wrapper itself contains no NOTICE file.

`claude-agent-acp` depends on `@anthropic-ai/claude-agent-sdk` 0.3.220. That
package points distributors to Anthropic's applicable commercial and consumer
terms. A distribution owner must complete its own legal review before shipping
this feature.

Memoh Desktop does not redistribute the native Codex or Claude Code CLI. Users
install those tools separately and remain responsible for their provider
accounts, authentication, local configuration, and terms.
201 changes: 201 additions & 0 deletions apps/desktop/resources/licenses/Apache-2.0.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/

TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION

1. Definitions.

"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.

"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.

"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.

"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.

"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.

"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.

"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).

"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.

"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."

"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.

2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.

3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.

4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:

(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and

(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and

(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and

(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.

You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.

5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.

6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.

8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.

9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.

END OF TERMS AND CONDITIONS

APPENDIX: How to apply the Apache License to your work.

To apply the Apache License to your work, attach the following
boilerplate notice, with the fields enclosed by brackets "[]"
replaced with your own identifying information. (Don't include
the brackets!) The text should be enclosed in the appropriate
comment syntax for the file format. We also recommend that a
file or class name and description of purpose be included on the
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
7 changes: 7 additions & 0 deletions apps/desktop/resources/licenses/OpenAI-Codex-NOTICE.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
OpenAI Codex
Copyright 2025 OpenAI

This project includes code derived from Ratatui
(https://github.com/ratatui/ratatui), licensed under the MIT license.
Copyright (c) 2016-2022 Florian Dehau
Copyright (c) 2023-2025 The Ratatui Developers
Loading
Loading