Repository navigation
Show the logo in the titlebar - #66
Merged
Merged
Conversation
The titlebar is three rows tall but only its middle row held anything. It now draws the mascot's head from assets/logo.svg in the first twelve columns, as a 12 by 6 pixel grid of half blocks in the logo's colours, and the name and the flash message move right to make room. Half blocks need nothing beyond truecolor, which the theme already assumes, so the logo shows over SSH and inside tmux too. Closes #65
The screenshot is captured from the app in tmux, against stand-in squeue, scontrol and sinfo scripts that serve the same sample queue as the old image. For the capture the table columns are sized to their content, since #41 still cuts them short at this width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The titlebar now shows the mascot's head in its first twelve columns, drawn with half blocks as a 12 by 6 pixel grid in the logo's colours, and the name and flash message sit to its right on the middle row. It needs only truecolor, which the theme already uses, so it shows over SSH and in tmux. Tests pin the logo's placement and check that a narrow or short bar clips it instead of panicking. The README screenshot is recaptured from the app against a fake queue with the same sample jobs, with the columns sized to their content for the capture because #41 still cuts them short.
Closes #65