Repository navigation
Stop the script pane scrolling past what it can draw - #64
Merged
Merged
Conversation
Paragraph::scroll takes a u16 and the script pane cast its usize offset straight into it, so past 65,535 rows the view jumped back near the top. Cap the scroll range there and clamp the cast. The log and custom panes no longer hit this since they draw only the visible lines; a test now pins that for the log pane at 70,000 lines.
fedonman
force-pushed
the
fixed/scroll-past-u16
branch
from
October 1, 2026 07:11
b137164 to
cc37f0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script pane cast its scroll offset straight to the
u16thatParagraph::scrolltakes, so past 65,535 rows the view jumped back near the top. It now stops scrolling at that row. The log and custom panes stopped hitting this when #56 made them draw only the visible lines, and a new test follows a 70,000-line log to its last line to keep it that way.Closes #37