Repository navigation
Run the startup SLURM queries before claiming the terminal - #59
Merged
Merged
Conversation
fedonman
force-pushed
the
fixed/probe-before-claiming-terminal
branch
from
September 28, 2026 14:26
3bf3c5a to
c909d03
Compare
main enabled raw mode and entered the alternate screen before building the Dashboard, whose constructor blocks on sinfo and sacctmgr, and run() then blocked on the first squeue before drawing anything. On a slow cluster the user got a blank screen, and with raw mode on, Ctrl+C was a key event nobody was reading. The Dashboard is now built first, with the first squeue moved from run() to the end of new(), so every blocking startup query runs on the normal terminal.
fedonman
force-pushed
the
fixed/probe-before-claiming-terminal
branch
from
September 29, 2026 10:02
c909d03 to
42127c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainentered raw mode and the alternate screen before building theDashboard, whose constructor blocks onsinfoandsacctmgr, andrun()then blocked on the firstsqueuebefore drawing a frame. On a slow cluster that left a blank screen, and with raw mode on, Ctrl+C was a key event nobody read. TheDashboardis now built first, and the firstsqueuemoves fromrun()to the end ofnew(), so every blocking startup query runs on the normal terminal where Ctrl+C works and an error is readable.Closes #24