Repository navigation
Stop the file watch of a hidden log pane - #58
Merged
Merged
Conversation
on_timer only drains visible panes, but a hidden pane kept its watch, and its reader sent the whole log into an unbounded channel every second, so memory grew by the log's size every second for as long as the pane stayed hidden. sync_widgets_to_focused_job now clears hidden log panes instead of keeping them on the focused job, and set_detail does nothing on a cleared pane, since the resolver pushes detail to every pane on each tick and that would start the watch again.
fedonman
force-pushed
the
fixed/stop-hidden-log-watches
branch
from
September 29, 2026 09:47
51757cd to
5cfd020
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_timeronly drains visible panes, but a hidden log pane kept its watch, and its reader sent the whole log into an unbounded channel every second that nothing read.sync_widgets_to_focused_jobnow clears hidden stdout, stderr and custom panes instead of keeping them on the focused job, which stops the watch, and showing a pane again reads the log from the start.set_detailnow does nothing on a cleared pane. Without that, the resolver pushing detail to every pane each tick would start the watch again. A test hides a pane, appends to its log and checks that nothing arrives.Closes #23