Repository navigation
Remember failed job lookups instead of retrying every frame - #57
Merged
Merged
Conversation
JobDetailResolver cached a job's detail only when scontrol succeeded, and draw() requests the focused job's detail on every frame, so once a lookup failed, for example because the job had aged out of slurmctld, sqwatch forked scontrol on every redraw for as long as the cursor stayed there. A failure now goes into the same LRU cache with its time, and the job is looked up again only after RETRY_AFTER (10 s), so a transient controller error still clears. The lookup is injectable so the tests can count calls without a real scontrol.
fedonman
force-pushed
the
fixed/cache-failed-job-lookups
branch
from
September 29, 2026 09:31
ecf7146 to
dc3bdc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JobDetailResolvercached a job's detail only whenscontrolsucceeded, anddraw()requests it on every frame, so a failed lookup forkedscontrolagain on each redraw for as long as the cursor stayed on the job. A failure now goes into the same LRU cache with its time, and the job is looked up again only after 10 seconds, so a job that has leftslurmctldcosts one lookup per 10 s and a transient controller error still clears up. The lookup is injectable so the tests can count calls without a realscontrol.Closes #22