Add Item on top feature#25
Open
abdullah951 wants to merge 1 commit into
Open
Conversation
federicoiosue
requested changes
Oct 18, 2021
Owner
federicoiosue
left a comment
federicoiosue
left a comment
There was a problem hiding this comment.
That's really great, you also followed the coding habits!
A couple of thing should be addressed before merging:
- Add some tests to check the desired behavior of the new feature
- Manage a little misbehavior: when adding a new item on top the order should be reversed by keeping the "cursor" sill on top and letting the last added item move on the second row, as shown in the screenshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the feature to add the new items to the top of list. Please have a look and share your thoughts. Here's the link for issue federicoiosue/Omni-Notes#816.
Here are some screenshots: