Skip to content

fix drag/drop for kanban when statuses are default#544

Merged
fccview merged 3 commits into
mainfrom
develop
Jun 16, 2026
Merged

fix drag/drop for kanban when statuses are default#544
fccview merged 3 commits into
mainfrom
develop

Conversation

@fccview

@fccview fccview commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes

    • Improved item drop/move behavior for legacy boards by resolving valid target statuses from the board’s configured statuses when available, or using default kanban statuses when not.
  • Tests

    • Added coverage for legacy board scenarios to verify correct acceptance/rejection of target statuses when the board has no explicit status definitions.
  • Chores

    • Bumped the app version to 1.25.1.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c9c6a92-2a03-4892-8b8c-584e6455ffcb

📥 Commits

Reviewing files that changed from the base of the PR and between d74bfdb and ec2697f.

📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

📝 Walkthrough

Walkthrough

dropItem in app/_server/actions/checklist-item/drop.ts gains a fallback: when list.statuses is absent or empty, the function now uses DEFAULT_KANBAN_STATUSES (imported from @/app/_consts/kanban) to resolve the valid status set before checking targetStatus. Two new Vitest tests cover this legacy-board path — one confirming acceptance of a default-matching targetStatus with a file-write side effect, and one confirming rejection of a non-default targetStatus with an error result and no file write. The package version was incremented from 1.25.0 to 1.25.1.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing drag/drop functionality for kanban boards when using default statuses, which is clearly reflected in the code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands and usage tips.

@fccview
fccview merged commit 3ebee0e into main Jun 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant