Skip to content

also check the command_keyword for duplication #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gconklin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

also check the command_keyword for duplication #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions webex_bot/webex_bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,21 @@ def add_command(self, command_class: Command):
"""

for c in self.commands:
log.debug(f"Checking command '{c}' against {command_class}")
command_class_name = type(command_class).__module__ + "." + type(command_class).__qualname__
c_name = type(c).__module__ + "." + type(c).__qualname__
log.debug(f"Checking command '{c_name}' against '{command_class_name}'")
new_command_keyword = command_class.command_keyword
new_callback_keyword = command_class.card_callback_keyword
duplicate = None
if new_callback_keyword and c.card_callback_keyword == new_callback_keyword:
raise Exception(f"Error adding new command: '{command_class.command_keyword}'. "
f"Duplicate callback_keyword found: "
f"'{new_callback_keyword}'. Use a unique keyword in your "
f"'{command_class.command_keyword}' adaptive card JSON.")
duplicate = new_callback_keyword
elif new_command_keyword and c.command_keyword == new_command_keyword:
duplicate = new_command_keyword

if duplicate:
raise Exception(f"Error adding new command: '{command_class_name}'. "
f"Duplicate keyword found: '{duplicate}' on existing {c_name}. "
f"Use a unique keyword for your commands.")

self.commands.add(command_class)

Expand Down