Fix for Useless assignment to local variable#26
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to remove a dead local assignment in analyzeLog by eliminating an if initializer that existed only to declare prepErr, and instead declaring variables closer to where they’re produced/used.
Changes:
- Removes the
if prepErr := error(nil); ...initializer inanalyzeLog. - Introduces a short variable declaration (
:=) when callingprepareAnalysisWithStore.
| if prepErr := error(nil); a != nil || errors.Is(err, engine.ErrNoMatch) { | ||
| a, prepErr = prepareAnalysisWithStore(a, string(data), "log", surface, opts, persist) | ||
| if a != nil || errors.Is(err, engine.ErrNoMatch) { | ||
| a, prepErr := prepareAnalysisWithStore(a, string(data), "log", surface, opts, persist) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General fix: remove dead local assignments and only declare variables when their value is actually produced/used.
Best fix here: in
internal/app/service.go, update theifstatement inanalyzeLogso it no longer initializesprepErrin theifinitializer. Instead, use a plain condition and declareprepErronly at the assignment fromprepareAnalysisWithStore(a, prepErr := ...). This preserves current functionality and keepsprepErrscoped to the block.No imports, new methods, or new definitions are needed.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.