fix(bulk): wire Mark flyout unlock to bulkUnlock - #39
Merged
fathiraz merged 1 commit intoJun 1, 2026
Merged
Conversation
The unlock verb in handleMarkVerb was calling bulkLock, which runs lockLockable instead of unlocking conversations. Add UNLOCK_ISSUE, bulkUnlock message/schema, and a background handler mirroring bulkUnpin.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38 (comment)
The Mark flyout Unlock conversations action called
bulkLock, so it ranlockLockableinstead of unlocking.Changes
UNLOCK_ISSUEGraphQL mutation (unlockLockable)bulkUnlockmessage type, schema, and background handler (mirrorsbulkUnpin)handleMarkVerb('unlock')tosendMessage('bulkUnlock', …)Verification
All passed (377 tests).
Summary by cubic
Fixes the Mark flyout “Unlock conversations” action so it actually unlocks items in bulk by adding a
bulkUnlockflow and GraphQL mutation.handleMarkVerb('unlock')tosendMessage('bulkUnlock', …).UNLOCK_ISSUEGraphQL mutation (unlockLockable).bulkUnlockmessage, schema, and background queue handler (mirrorsbulkUnpin).Written for commit 56d95b8. Summary will update on new commits.