fix(desktop): unblock note sharing#6202
Merged
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
ComputelessComputer
force-pushed
the
fix/share-note-loading
branch
from
July 22, 2026 07:16
307b46b to
b104669
Compare
ComputelessComputer
force-pushed
the
fix/share-note-loading
branch
from
July 22, 2026 07:31
b104669 to
41b9176
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 41b9176. Configure here.
Scope share preparation writes to the active note and cache, and resize the share popover to 320x240.
ComputelessComputer
force-pushed
the
fix/share-note-loading
branch
from
July 22, 2026 07:35
41b9176 to
82f9e69
Compare
Add contact-aware invitations, member permissions, and authenticated transactional email delivery.
Adopt a Granola-style document shell and keep comments anchored in Linear-style side cards without a duplicate bottom feed.
ComputelessComputer
force-pushed
the
fix/share-note-loading
branch
from
July 22, 2026 07:41
82f9e69 to
b49b71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Scope share preparation writes to the active note and cache, and resize the share popover to 320x240.
Note
Medium Risk
Keyed flush changes persistence timing for sharing and could affect race behavior if callers pass wrong keys; the new email endpoint touches auth and third-party email delivery.
Overview
Unblocks desktop note sharing by letting
flushDatabaseWritestarget specific queue keys (e.g.session:{id}) so share preparation waits only on that note’s writes, not unrelated background sync. Per-key flush also drains newer writes on the same key before surfacing an earlier failure, with tests covering both behaviors. Share flows call the keyed flush when loading share source and flushing canonical editor changes.Adds server support for invitation emails:
POST /shared-notes/invitations/{invitation_id}/email(OpenAPI +SharedNoteInvitationEmailRequest) and wiresSharedNotesConfigwith Loops viawith_invitation_emailin API startup (api-syncgainsloopsdependency).Refreshes session-sharing i18n—drops older copy (e.g. copy-invite, long conflict instructions) in favor of shorter labels for invite, access levels (full / invited-only), restrict, and share.
Reviewed by Cursor Bugbot for commit b49b71b. Bugbot is set up for automated code reviews on this repo. Configure here.
This is part 1 of 2 in a stack made with GitButler: