Skip to content

fix(desktop): unblock note sharing#6202

Merged
ComputelessComputer merged 3 commits into
mainfrom
fix/share-note-loading
Jul 22, 2026
Merged

fix(desktop): unblock note sharing#6202
ComputelessComputer merged 3 commits into
mainfrom
fix/share-note-loading

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Scope share preparation writes to the active note and cache, and resize the share popover to 320x240.


Note

Medium Risk
Keyed flush changes persistence timing for sharing and could affect race behavior if callers pass wrong keys; the new email endpoint touches auth and third-party email delivery.

Overview
Unblocks desktop note sharing by letting flushDatabaseWrites target specific queue keys (e.g. session:{id}) so share preparation waits only on that note’s writes, not unrelated background sync. Per-key flush also drains newer writes on the same key before surfacing an earlier failure, with tests covering both behaviors. Share flows call the keyed flush when loading share source and flushing canonical editor changes.

Adds server support for invitation emails: POST /shared-notes/invitations/{invitation_id}/email (OpenAPI + SharedNoteInvitationEmailRequest) and wires SharedNotesConfig with Loops via with_invitation_email in API startup (api-sync gains loops dependency).

Refreshes session-sharing i18n—drops older copy (e.g. copy-invite, long conflict instructions) in favor of shorter labels for invite, access levels (full / invited-only), restrict, and share.

Reviewed by Cursor Bugbot for commit b49b71b. Bugbot is set up for automated code reviews on this repo. Configure here.


This is part 1 of 2 in a stack made with GitButler:

@netlify

netlify Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit b49b71b
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a607431f0276100088f48a6

Comment thread apps/desktop/src/session-sharing/index.tsx

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 41b9176. Configure here.

Comment thread apps/desktop/src/db/write-queue.ts
Scope share preparation writes to the active note and cache, and resize the share popover to 320x240.
Add contact-aware invitations, member permissions, and authenticated transactional email delivery.
Adopt a Granola-style document shell and keep comments anchored in Linear-style side cards without a duplicate bottom feed.
@ComputelessComputer
ComputelessComputer merged commit ebaa455 into main Jul 22, 2026
17 checks passed
@ComputelessComputer
ComputelessComputer deleted the fix/share-note-loading branch July 22, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant