Keep local database operations responsive during sync#6201
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3b8cd3f. Configure here.
Narrow the CloudSync reconciliation barrier while keeping destructive resets isolated from renderer writes.
ComputelessComputer
force-pushed
the
fix/local-crud-during-cloudsync
branch
from
July 22, 2026 07:25
3b8cd3f to
11fa15c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Remove the CloudSync reconciliation barrier from renderer SQL while preserving native synced-write serialization.
Note
Medium Risk
Changes serialization timing around CloudSync workspace projection and E2EE cutover; race windows could affect sync consistency if assumptions about suspend/reconcile ordering are wrong.
Overview
CloudSync workspace projection reconciliation no longer holds the
synced_write_barrierwrite lock for the wholeconfigure_cloudsync_token_with_projection_innerflow. Validation, workspace claim, andcloudsync_suspendrun first; the write lock is taken only after suspend when a projection is present. It is released explicitly aftercommit_cloudsync_workspace_projectionand beforeapply_cloudsync_config_fail_closed, so renderer SQL (execute, transactions, proxy) can proceed during the final CloudSync reconfigure/start instead of staying blocked for the entire E2EE and staging work.Tests for
reconciliation_barrier_blocks_renderer_writesnow assert that all three renderer write entry points block while the write guard is held and succeed after it is dropped.Reviewed by Cursor Bugbot for commit 11fa15c. Bugbot is set up for automated code reviews on this repo. Configure here.