test(orm): remove FakeSeeder test double, assert via autospec mock - #176
Merged
Conversation
Replace the hand-rolled FakeSeeder class in test_db_seed_command.py with mock.patch(..., autospec=True) against the real Seeder, asserting constructor args and awaited calls directly. Same cleanup already applied on the PR #155 branch (commit 8471bd9) but missed on the experiments seeds->seeders refactor (PR #175).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FakeSeedertest double fromtest_db_seed_command.pyonexperimentsmock.patch("fastapi_startkit.masoniteorm.seeders.Seeder", autospec=True), asserting constructor args and awaited calls directly (assert_called_once_with,assert_awaited_once_with)masoniteorm.seeders)assertRaisesviaCommandTester._runTest plan
grep -rn FakeSeeder .returns nothinguv run pytest tests/masoniteorm/commands/ -v— 41 passed, 1 skippeduv run pytest --ignore=tests/masoniteorm/postgres— 1837 passed, 7 skipped (no regressions)uv run ruff check .anduv run ruff format --check .— clean🤖 Generated with Claude Code