Skip to content

chore: remove deleted masoniteorm.backup files - #156

Merged
tmgbedu merged 1 commit into
mainfrom
chore/remove-masoniteorm-backup
Jul 9, 2026
Merged

chore: remove deleted masoniteorm.backup files#156
tmgbedu merged 1 commit into
mainfrom
chore/remove-masoniteorm-backup

Conversation

@tmgbedu

@tmgbedu tmgbedu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

The maintainer manually deleted several stale files under masoniteorm.backup/ in the working tree. This PR commits those deletions.

Removed files:

  • fastapi_startkit/src/fastapi_startkit/masoniteorm.backup/config.py
  • fastapi_startkit/src/fastapi_startkit/masoniteorm.backup/config/database.py
  • fastapi_startkit/src/fastapi_startkit/masoniteorm.backup/factories/Factory.py
  • fastapi_startkit/src/fastapi_startkit/masoniteorm.backup/factories/__init__.py
  • fastapi_startkit/src/fastapi_startkit/masoniteorm.backup/schema/Schema.py

Scope

Only these 5 deletions under masoniteorm.backup/ are included — no unrelated changes were swept in. The rest of the masoniteorm.backup/ directory is untouched.

Testing

uv run pytest --ignore=tests/masoniteorm/postgres1650 passed, 7 skipped. The only failures in a full run are the live-Postgres tests that require a running database (unrelated to this change).

Remove five stale files under masoniteorm.backup/ that were deleted from
the working tree: config.py, config/database.py, factories/Factory.py,
factories/__init__.py, and schema/Schema.py.
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@tmgbedu

tmgbedu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Code Review: APPROVE (posted as comment — GitHub blocks self-approval; not merging, per standing order)

Scope — single commit 3a83205e, exactly the 5 intended deletions, 0 additions / 597 deletions, all under masoniteorm.backup/. Nothing outside that directory is touched.

Dangling references — grep of src/ and tests/ finds no import of the deleted modules (config.py, config/database.py, factories/Factory.py, factories/init.py, schema/Schema.py). No remaining backup file references them internally either.

Safetymasoniteorm.backup is in norecursedirs in pyproject.toml, so pytest never collects it; these deletions are provably inert to the suite.

Testsuv run pytest --ignore=tests/masoniteorm/postgres1650 passed, 7 skipped. Only live-Postgres tests excluded (require a running DB; unrelated).

LGTM — safe to merge at maintainer's discretion.

@tmgbedu
tmgbedu merged commit fdc2ca7 into main Jul 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant