Skip to content

chore: remove repo-root queue.py proof-of-concept - #151

Merged
tmgbedu merged 1 commit into
mainfrom
task/remove-queue-poc
Jul 9, 2026
Merged

chore: remove repo-root queue.py proof-of-concept#151
tmgbedu merged 1 commit into
mainfrom
task/remove-queue-poc

Conversation

@tmgbedu

@tmgbedu tmgbedu commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What

Deletes the repo-root queue.py proof-of-concept script (repo root only — copies under .claude/worktrees and .venv are untouched).

References

None to remove. queue.py is a standalone if __name__ == "__main__" demo (run via python queue.py) with no importers:

  • No import queue / from queue import ... anywhere in the codebase resolves to this module (nothing imports it at all — stdlib or otherwise).
  • The only queue.py mention was a self-referential comment inside the file itself.
  • The docs hit docs/queues.md → config/queue.py refers to a config-file example, not this root POC — unrelated.

Verification

  • grep -rn queue.py . (excluding .git/worktrees) → 0 matches after deletion
  • No import queue / from queue references anywhere
  • uv sync --group dev in fastapi_startkit/exit 0, resolves cleanly

Standalone __main__ demo script with no importers anywhere in the repo.
Deleting it leaves the build green.

@tmgbedu tmgbedu left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review verdict: APPROVE (posting as comment — GitHub blocks self-approval on own PR).

Single-file deletion of repo-root queue.py (346 deletions, 0 additions). All four review checks pass:

  1. Scope — PR branch diff (main...origin/task/remove-queue-poc) is exactly 1 file: queue.py. Copies under .claude/worktrees / .venv are not in the diff — untouched. ✅
  2. No references / importersgrep -rn queue.py (excl .git/worktrees) → only remaining hit is the self-referential comment inside the deleted file (# Demo (python queue.py)), which goes away with it. No import queue / from queue import anywhere resolves to this module. ✅
  3. Docs unaffected — the only docs mentions are # config/queue.py in queues.md, a config-file example unrelated to this root POC. ✅
  4. Clean syncqueue.py is not referenced as a script/entry-point in any pyproject.toml; no lock or other files in the diff. uv sync unaffected. ✅

Bonus: a root-level queue.py shadows the stdlib queue module when running python from the repo root — removing it eliminates that latent hazard.

Clean removal. LGTM.

@tmgbedu
tmgbedu merged commit 1985b37 into main Jul 9, 2026
3 checks passed
@tmgbedu
tmgbedu deleted the task/remove-queue-poc branch July 9, 2026 16:15
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant